WIP: Better Handling for Permissions #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI portion of dockstore/dockstore#1589 This has a dependency on PR dockstore/dockstore#1638, which has a new endpoint. Call new endpoint to get allowable actions. If SHARE action is one of the actions, then user is an owner, and go ahead and fetch all permissions for the workflow. Unfortunately, generated TS code doesn't generate a type for the enum returned by Actions.
garyluu
approved these changes
Jul 27, 2018
agduncan94
approved these changes
Jul 27, 2018
|
@coverbeck Hmmm, seems like a legitimate failure |
|
Checking... |
Codecov Report
@@ Coverage Diff @@
## develop #367 +/- ##
==========================================
Coverage ? 64.93%
==========================================
Files ? 149
Lines ? 5059
Branches ? 509
==========================================
Hits ? 3285
Misses ? 1667
Partials ? 107Continue to review full report at Codecov.
|
denis-yuen
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI portion of dockstore/dockstore#1589
This has a dependency on PR dockstore/dockstore#1638, which has a new
endpoint.
Call new endpoint to get allowable actions. If SHARE action is one
of the actions, then user is an owner, and go ahead and fetch all
permissions for the workflow.
Unfortunately, generated TS code doesn't generate a type for the enum
returned by Actions.