Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump elliptic from 6.5.7 to 6.6.0 #2041

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 31, 2024

Bumps elliptic from 6.5.7 to 6.6.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0.
- [Commits](indutny/elliptic@v6.5.7...v6.6.0)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 31, 2024
@dependabot dependabot bot requested review from a team, denis-yuen, david4096 and hyunnaye and removed request for a team October 31, 2024 15:03
Copy link

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.41%. Comparing base (83677d4) to head (4f764a2).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2041      +/-   ##
===========================================
- Coverage    41.67%   41.41%   -0.26%     
===========================================
  Files          394      394              
  Lines        12315    12315              
  Branches      2959     2959              
===========================================
- Hits          5132     5100      -32     
- Misses        4858     4892      +34     
+ Partials      2325     2323       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen self-assigned this Nov 7, 2024
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough

@denis-yuen denis-yuen requested a review from coverbeck November 7, 2024 15:09
Copy link
Collaborator

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little wary of the minor dependency upgrade, but this is only used via a dev dependency, so worst case it shouldn't break anything deployed.

 npm ls elliptic         
dockstore-ui2@2.13.0 /Users/charlesoverbeck/git/dockstore/dockstore-ui2
└─┬ @cypress/webpack-batteries-included-preprocessor@2.4.1
  └─┬ webpack@4.47.0
    └─┬ node-libs-browser@2.2.1
      └─┬ crypto-browserify@3.12.0
        ├─┬ browserify-sign@4.2.2
        │ └── elliptic@6.5.7
        └─┬ create-ecdh@4.0.4
          └── elliptic@6.5.7 deduped

@denis-yuen denis-yuen merged commit f145992 into develop Nov 7, 2024
19 checks passed
@denis-yuen denis-yuen deleted the dependabot/npm_and_yarn/elliptic-6.6.0 branch November 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants