Use stable 2.3.1 swagger codgen #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-yuen
reviewed
Jan 24, 2018
| @@ -173,7 +173,7 @@ export class ContainerComponent extends Entry { | |||
|
|
|||
| // Only get published tool if the URI is for a specific tool (/containers/quay.io%2FA2%2Fb3) | |||
| // as opposed to just /tools or /docs etc. | |||
| this.containersService.getPublishedContainerByToolPath(this.title, this._toolType) | |||
There was a problem hiding this comment.
was an explanation discovered for this disappearing parameter?
There was a problem hiding this comment.
This is what I think happened.
- We were originally not using the swagger generated methods and we had our own method with an extra parameter to differentiate between tool/workflow.
- We swapped the methods to the swagger-generated ones but didn't remove that extra parameter during the change. The swagger-generated methods so happen to allow an extra parameter with type 'any'. so it still worked but didn't really do anything significant with that extra parameter.
With the new 2.3.1 swagger generated methods, it appears they removed this 'any' type parameter so it no longer works.
| @@ -152,7 +152,7 @@ export class WorkflowComponent extends Entry { | |||
|
|
|||
| // Only get published workflow if the URI is for a specific workflow (/containers/quay.io%2FA2%2Fb3) | |||
| // as opposed to just /tools or /docs etc. | |||
| this.workflowsService.getPublishedWorkflowByPath(this.title, this._toolType) | |||
denis-yuen
approved these changes
Jan 25, 2018
agduncan94
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to use the stable 2.3.1 swagger codegen