Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Search UI Updates #1764

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Minor Search UI Updates #1764

merged 3 commits into from
Apr 28, 2023

Conversation

KimberleyChong
Copy link
Contributor

@KimberleyChong KimberleyChong commented Apr 27, 2023

Description
Almost unnoticeable changes to the search tables... but I think it makes a difference, following the mocks:

  • More padding around the entire table
  • More padding between table rows
  • Slightly smaller bubble sizes for "Format" entries
  • Make the name column wider and the Author column a bit smaller
  • Change heading "Name" -> "Name & Description"
  • Purple stars and bolded text, switch order so star first then number

Before - Search page workflows:
image

After - Search page workflows:
image

Before - Search page tools:
image

After - Search page tools:
image

For entry specific search pages:

  • Use friendly descriptor type names
  • Same changes to starred - purple, bolded, swap order

Before:
image
After:
image

Before After
image image

Review Instructions
Search tables look like images attached.

Issue
SEAB-5257

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@KimberleyChong KimberleyChong self-assigned this Apr 27, 2023
@KimberleyChong KimberleyChong marked this pull request as ready for review April 27, 2023 21:13
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change heading "Name" -> "Name & Description"

Thinking you have the room for "Name and Description" if going down this route

@KimberleyChong
Copy link
Contributor Author

  • Change heading "Name" -> "Name & Description"

Thinking you have the room for "Name and Description" if going down this route

Yeah, I went with the mocks but had a feeling you would prefer and over & 😁

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KimberleyChong KimberleyChong merged commit f31076c into release/1.14 Apr 28, 2023
@KimberleyChong KimberleyChong deleted the SEAB-5257/search-ui branch April 28, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants