Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Warning Banner Enhancements #1763

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

KimberleyChong
Copy link
Contributor

@KimberleyChong KimberleyChong commented Apr 26, 2023

Description
Some improvements to the previewWarningBanner following feedback and suggestions:

  • Change banner colour from alert-info to alert-warning
  • Parameterize the banner to display the input featureName to provide more information on what the banner is referring to
  • Fix spacing for the starred Notebooks tab so it aligns with the other banner when no starred Notebooks

Colour Change:

  • Before:
    image
  • After:
    image

Spacing Fix:

  • Before:
    image

  • After:
    image

Additional
The user dropdown was bugging me... when you hover it doesn't look clickable 🤔 minor fix:

  • Before:
    image
  • After:
    image

Review Instructions
Preview banner should say "Notebooks is an early access feature..." etc instead of "This is an early access feature...", banner should be yellow and follow images attatched.

Issue
SEAB-5262

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@KimberleyChong KimberleyChong self-assigned this Apr 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KimberleyChong KimberleyChong requested review from kathy-t, coverbeck, denis-yuen and svonworl and removed request for coverbeck and kathy-t April 27, 2023 13:29
@denis-yuen denis-yuen marked this pull request as ready for review April 27, 2023 14:29
@KimberleyChong KimberleyChong merged commit 3d39d94 into release/1.14 Apr 27, 2023
@KimberleyChong KimberleyChong deleted the SEAB-5262/parameterize-preview-banner branch April 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants