Fix login to create tokens of the same scope as account linking #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
========================================
Coverage 63.14% 63.14%
========================================
Files 94 94
Lines 2724 2724
Branches 360 360
========================================
Hits 1720 1720
Misses 815 815
Partials 189 189Continue to review full report at Codecov.
|
denis-yuen
requested review from
agduncan94 and
garyluu
and removed request for
agduncan94 and
garyluu
|
FYI, I added this as a hotfix too (accidentally, but it probably should be in there too) |
garyluu
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one line/error took entirely too long to discover.
The issue was that logging in would create a token of completely different scope from the linking account button, causing newly logged in users to be unable to refresh workflows out of the box.