-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3741/smoke test documentation #1419
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## develop #1419 +/- ##
========================================
Coverage 43.87% 43.87%
========================================
Files 301 301
Lines 9058 9058
Branches 2159 2159
========================================
Hits 3974 3974
Misses 3311 3311
Partials 1773 1773
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, git-secrets should catch any tokens, but the extra caution is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Especially like that the documentation calls out common reasons for smoke test failures in CI, and that it also covers the smoke test database. Great improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real Chaz Reid giving approval this time. I agree with my evil twin
Description
Smoke test documentation update.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-3741
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities