Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3741/smoke test documentation #1419

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

Richard-Hansen
Copy link
Contributor

Description
Smoke test documentation update.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-3741

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain

@Richard-Hansen Richard-Hansen self-assigned this Dec 21, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1419 (4b18b2c) into develop (97af6ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1419   +/-   ##
========================================
  Coverage    43.87%   43.87%           
========================================
  Files          301      301           
  Lines         9058     9058           
  Branches      2159     2159           
========================================
  Hits          3974     3974           
  Misses        3311     3311           
  Partials      1773     1773           
Impacted Files Coverage Δ
...me-page/home-logged-in/home-logged-in.component.ts 57.89% <0.00%> (-5.27%) ⬇️
...rc/app/home-page/home-logged-out/home.component.ts 71.42% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97af6ae...4b18b2c. Read the comment docs.

@Richard-Hansen Richard-Hansen marked this pull request as ready for review December 21, 2021 20:06
Copy link
Collaborator

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, git-secrets should catch any tokens, but the extra caution is good.

Copy link

@chmreid2 chmreid2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Especially like that the documentation calls out common reasons for smoke test failures in CI, and that it also covers the smoke test database. Great improvement!

Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real Chaz Reid giving approval this time. I agree with my evil twin

@Richard-Hansen Richard-Hansen merged commit b001acb into develop Dec 21, 2021
@Richard-Hansen Richard-Hansen deleted the feature/3741/smokeTestDocumentation branch December 21, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants