Feature/organization fixes (#541)

* Don't null the description, change URL * Fix ng test * Add cypress test
dockstore · Feb 8, 2019 · eb05f37 · eb05f37
1 parent c4248f4
commit eb05f37
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/cypress/integration/group3/organizations.ts b/cypress/integration/group3/organizations.ts
@@ -73,6 +73,7 @@ describe('Dockstore Organizations', () => {
       typeInInput('Location', 'UCSC Basement');
       typeInInput('Contact Email Address', 'asdf@asdf.com');
       cy.get('#createOrUpdateOrganizationButton').should('be.visible').should('not.be.disabled').click();
+      cy.url().should('eq', Cypress.config().baseUrl + '/organizations/Potatoe');
     });
 
     it('have new fields reflected', () => {

diff --git a/src/app/organizations/state/register-organization.service.spec.ts b/src/app/organizations/state/register-organization.service.spec.ts
@@ -50,7 +50,7 @@ describe('RegisterOrganizationService', () => {
   it('should handle error when updating an organization', () => {
     organisationsServiceSpy.updateOrganisation.and.returnValue(throwError('test 404 error'));
 
-    registerOrganizationService.updateOrganization(exampleFormState, 1);
+    registerOrganizationService.updateOrganization(exampleFormState, 1, 'potato');
 
     // Expected createOrganisation call to be called (even though it will fail)
     expect(organisationsServiceSpy.updateOrganisation.calls.count()).toBe(1, 'spy method was called once');
@@ -62,7 +62,7 @@ describe('RegisterOrganizationService', () => {
     organisationsServiceSpy.updateOrganisation.and.returnValue(observableOf(null));
     matDialogSpy.closeAll.and.returnValue(null);
 
-    registerOrganizationService.updateOrganization(exampleFormState, 1);
+    registerOrganizationService.updateOrganization(exampleFormState, 1, 'potato');
 
     // Expected createOrganisation call to be called (and it will succeed)
     expect(organisationsServiceSpy.updateOrganisation.calls.count()).toBe(1, 'spy method was called once');

diff --git a/src/app/organizations/state/register-organization.service.ts b/src/app/organizations/state/register-organization.service.ts
@@ -64,7 +64,7 @@ export class RegisterOrganizationService {
     if (data.mode === TagEditorMode.Add) {
       this.createOrganization(form.value);
     } else {
-      this.updateOrganization(form.value, data.organization.id);
+      this.updateOrganization(form.value, data.organization.id, data.organization.description);
     }
   }
 
@@ -165,7 +165,8 @@ export class RegisterOrganizationService {
    * @returns {void}
    * @memberof RegisterOrganizationService
    */
-  updateOrganization(organizationFormState: FormsState['registerOrganization'], organizationId: number): void {
+  updateOrganization(organizationFormState: FormsState['registerOrganization'], organizationId: number,
+  organizationDescription: string): void {
     if (!organizationFormState) {
       console.error('Something has gone terribly wrong with the form manager');
       return;
@@ -177,13 +178,16 @@ export class RegisterOrganizationService {
         location: organizationFormState.location,
         email: organizationFormState.contactEmail,
         status: Organisation.StatusEnum.PENDING,
+        description: organizationDescription,
         users: []
       };
       this.alertService.start('Updating organization');
       this.organisationsService.updateOrganisation(organizationId, editedOrganization).subscribe((organization: Organisation) => {
         this.matDialog.closeAll();
         if (organization) {
           this.alertService.detailedSuccess();
+          // Watch out if this function is executed on Dockstore UI where it's not /organizations/{organizationId}
+          this.router.navigate(['/organizations', editedOrganization.name]);
           this.organizationService.updateOrganizationFromID(organizationId);
         } else {
           console.error('No idea how it would successfully return no organization');