fix TRS link for Galaxy workflows

https://ucsc-cgl.atlassian.net/browse/DOCK-2496 dockstore/dockstore#5751
dockstore · Dec 7, 2023 · d58322b · d58322b
1 parent 56236cb
commit d58322b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/src/app/descriptor-languages/Jupyter.ts b/src/app/descriptor-languages/Jupyter.ts
@@ -15,8 +15,8 @@ export const extendedJupyter: ExtendedDescriptorLanguageBean = {
   toolDescriptorEnum: ToolDescriptor.TypeEnum.JUPYTER,
   workflowDescriptorEnum: Workflow.DescriptorTypeEnum.Jupyter,
   languageDocumentationURL: JUPYTER_DOCUMENTATION_URL,
-  plainTRS: null,
-  descriptorFileTypes: [],
+  plainTRS: 'PLAIN_JUPYTER',
+  descriptorFileTypes: [SourceFile.TypeEnum.DOCKSTOREJUPYTER],
   toolTab: {
     rowIdentifier: 'tool\xa0ID',
     workflowStepHeader: 'Notebook',

diff --git a/src/app/workflow/info-tab/info-tab.service.spec.ts b/src/app/workflow/info-tab/info-tab.service.spec.ts
@@ -59,4 +59,14 @@ describe('ValueService', () => {
     expect(service.getTRSId(sampleWorkflow3, EntryType.Service)).toBe(`#service/${fullWorkflowPath}`);
     expect(service.getTRSId(null, EntryType.BioWorkflow)).toBe('');
   });
+
+  it(`getTRSPlainType should work for various descriptor types`, () => {
+    service = TestBed.inject(InfoTabService);
+    expect(service.getTRSPlainType('CWL')).toBe('PLAIN_CWL');
+    expect(service.getTRSPlainType('WDL')).toBe('PLAIN_WDL');
+    expect(service.getTRSPlainType('NFL')).toBe('PLAIN_NFL');
+    expect(service.getTRSPlainType('gxformat2')).toBe('PLAIN_GALAXY');
+    expect(service.getTRSPlainType('jupyter')).toBe('PLAIN_JUPYTER');
+    expect(service.getTRSPlainType('bogus')).toBe('PLAIN_BOGUS');
+  });
 });
diff --git a/src/app/workflow/info-tab/info-tab.service.ts b/src/app/workflow/info-tab/info-tab.service.ts
@@ -218,13 +218,21 @@ export class InfoTabService {
   getTRSLink(path: string, versionName: string, descriptorType: string, descriptorPath: string, entryType: EntryType): string {
     return (
       `${Dockstore.API_URI}${ga4ghPath}/tools/${encodeURIComponent(this.getTRSIDFromPath(path, entryType))}` +
-      `/versions/${encodeURIComponent(versionName)}/PLAIN_` +
-      descriptorType.toUpperCase() +
+      `/versions/${encodeURIComponent(versionName)}/` +
+      this.getTRSPlainType(descriptorType) +
       `/descriptor/` +
       descriptorPath
     );
   }
 
+  getTRSPlainType(dockstoreDescriptorType: string): string {
+    const trsDescriptorType = this.descriptorTypeCompatService.stringToDescriptorType(dockstoreDescriptorType);
+    return (
+      this.descriptorTypeCompatService.toolDescriptorTypeEnumToPlainTRS(trsDescriptorType) ??
+      `PLAIN_${dockstoreDescriptorType.toUpperCase()}`
+    );
+  }
+
   getTRSId(workflow: Workflow | undefined, entryType: EntryType): string {
     if (!workflow) {
       return '';