Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebP support for PHP GD #91

Merged
merged 7 commits into from
Jan 4, 2019
Merged

Add WebP support for PHP GD #91

merged 7 commits into from
Jan 4, 2019

Conversation

sean-e-dietrich
Copy link
Member

Following Mike Hershel's Tweet https://twitter.com/mikeherchel/status/1053790762759008262

Confirmed that while Chrome is probably the ONLY browser that will support WebP processing. Chrome is widely used and found that CLI does not have WebP compiled.

5.6 Image has a different flag then 7.0+

@lmakarov
Copy link
Member

We can certainly include WebP support in docksal/cli.

However and FYI, it is not currently supported on either Acquia or Pantheon.
So a project hosted with one of these providers won't be able to use WebP anyway.

Would be also good to know whether Platform.sh supports WebP or not. I don't have any projects there so cannot validate this.


Acquia

print_r(gd_info());
Array
(
    [GD Version] => bundled (2.1.0 compatible)
    [FreeType Support] => 1
    [FreeType Linkage] => with freetype
    [GIF Read Support] => 1
    [GIF Create Support] => 1
    [JPEG Support] => 1
    [PNG Support] => 1
    [WBMP Support] => 1
    [XPM Support] => 1
    [XBM Support] => 1
    [WebP Support] => 
    [JIS-mapped Japanese Font Support] => 
)

Pantheon

print_r(gd_info());
Array
(
    [GD Version] => bundled (2.1.0 compatible)
    [FreeType Support] => 1
    [FreeType Linkage] => with freetype
    [GIF Read Support] => 1
    [GIF Create Support] => 1
    [JPEG Support] => 1
    [PNG Support] => 1
    [WBMP Support] => 1
    [XPM Support] => 1
    [XBM Support] => 1
    [WebP Support] => 
    [JIS-mapped Japanese Font Support] => 
)

Docksal (docksal/cli:2.5-php7.1)

print_r(gd_info());
Array
(
    [GD Version] => bundled (2.1.0 compatible)
    [FreeType Support] => 1
    [FreeType Linkage] => with freetype
    [GIF Read Support] => 1
    [GIF Create Support] => 1
    [JPEG Support] => 1
    [PNG Support] => 1
    [WBMP Support] => 1
    [XPM Support] => 
    [XBM Support] => 1
    [WebP Support] => 
    [JIS-mapped Japanese Font Support] => 
)

@sean-e-dietrich
Copy link
Member Author

Platform.sh does have support for WebP.

screen shot 2018-10-28 at 7 35 05 pm

@achekulaev
Copy link
Member

achekulaev commented Nov 15, 2018

I almost feel like we need a repo/doc of common cli extensions in form of repo with Dockerfiles, so that instead of adding those yet-another-tool-someone-needs things to the cli image we could just show people how to easily get those on the per-project basis using custom Dockerfile example from that repo/doc.

@lmakarov
Copy link
Member

lmakarov commented Jan 4, 2019

@sean-e-dietrich tests are still failing and we now also need to add PHP 7.3 support.

@lmakarov lmakarov self-assigned this Jan 4, 2019
@sean-e-dietrich
Copy link
Member Author

@lmakarov just checked and the build is now passing we were missing a few packages. Additionally looks like the support has also been translated for PHP7.3 now too.

@lmakarov lmakarov changed the title Add WebP support for PHP GD [WIP] Add WebP support for PHP GD Jan 4, 2019
@lmakarov lmakarov merged commit 0ad87d6 into develop Jan 4, 2019
@lmakarov lmakarov deleted the webp branch January 4, 2019 20:00
@lmakarov lmakarov mentioned this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants