Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with empty SECRET_SSH_PRIVATE_KEY prevent SSH authentication #82

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fix issue with empty SECRET_SSH_PRIVATE_KEY prevent SSH authentication #82

merged 1 commit into from
Aug 24, 2018

Conversation

asgorobets
Copy link
Contributor

@asgorobets asgorobets commented Aug 23, 2018 •
edited
Loading

Closes #81

@achekulaev
Copy link
Member

@lmakarov I don't completely understand why tests fail for this one

@lmakarov
Copy link
Member

@achekulaev we don not expose secrets to forked PR builds, so Platform.sh and Pantheon integrations will always fail for these. We may have to adjust those tests to be skipped on forked builds.

lmakarov
lmakarov approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@lmakarov lmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmakarov lmakarov merged commit 2ec42fc into docksal:develop Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmakarov lmakarov lmakarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asgorobets @achekulaev @lmakarov