Cloud9 IDE integration #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ditch nvm and install Node.js globally from NodeSource repos - List images after build (to check image sizes)
- Starting supervisord using /etc/supervisor/supervisord.conf config, which includes /etc/supervisor/conf.d/*.conf - Removed non-essential settings from the custom supervisor.conf - pretty much all of them are covered in /etc/supervisor/supervisord.conf (in Debian Stretch)
|
Alternative way of installing node and yarn from binaries: ENV NODE_VERSION=8.11.2
ENV YARN_VERSION 1.5.1
RUN set -xe; \
# Nodejs
curl -fsSLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz"; \
tar -xJf "node-v$NODE_VERSION-linux-x64.tar.xz" -C /usr/local --strip-components=1; \
rm -f "node-v$NODE_VERSION-linux-x64.tar.xz"; \
ln -s /usr/local/bin/node /usr/local/bin/nodejs; \
# Yarn
curl -fsSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz"; \
tar -xzf yarn-v$YARN_VERSION.tar.gz -C /opt/; \
ln -s /opt/yarn-v$YARN_VERSION/bin/yarn /usr/local/bin/yarn; \
ln -s /opt/yarn-v$YARN_VERSION/bin/yarnpkg /usr/local/bin/yarnpkg; \
rm -f yarn-v$YARN_VERSION.tar.gz;This adds 60.9MB vs 53.9MB when installing from packages. |
|
@lmakarov why are we using outdated nodejs? |
|
@achekulaev 8.11.2 is the current LTS release. |
|
@lmakarov no 10.x is current LTS https://en.wikipedia.org/wiki/Node.js |
|
@achekulaev per http://nodejs.org/ |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: docksal/docksal#568