Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have master and release tag images match #56

Closed
lmakarov opened this issue Jun 14, 2018 · 2 comments
Closed

Have master and release tag images match #56

lmakarov opened this issue Jun 14, 2018 · 2 comments

Comments

@lmakarov
Copy link
Member

With the current build/release process release tags are built separately (when a tag is published) from the master branch.

docksal/cli:<image-version>-php<php-version> != docksal/cli:php<php-version>

They should match.

This can be achieved by building tags from the latest stable versions instead if from scratch:

FROM docksal/cli:php<php-version>
@achekulaev
Copy link
Member

You can just provide several tags during build

docker build -t whenry/fedora-jboss:latest -t whenry/fedora-jboss:v2.1 .

@lmakarov
Copy link
Member Author

Branch and tags builds happen separately. Tags are built when a release tag is published on Github.

We could technically override the stable version tags when release tags are built and published, but that sounds like a waste of CI resources to me.

lmakarov added a commit that referenced this issue Jun 22, 2018
- Moved the push script into a standalone file - scripts/docker-push.sh
lmakarov added a commit that referenced this issue Jun 23, 2018
Make sure the latest release and stable tags match. Closes #56
@lmakarov lmakarov mentioned this issue Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants