replaces mailhog with mailpit #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmakarov
requested changes
Apr 2, 2024
There was a problem hiding this comment.
PHP_INI and MAILHOG_INI are no longer relevant for mailpit (nor where they for mailhog) since this change in docksal/cli - docksal/service-cli#103
@shelane Can you please update the mailpit addon to remove the unnecessary code?
|
Yeah, I had removed that. The mailpit directory does not contain the ini file and the whole mailhog directory is being deleted with this request. |
|
Ah, I see where you mean. Fixing now. |
lmakarov
requested changes
Apr 3, 2024
lmakarov
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the abandoned mailhog with mailpit and updating the yaml file based on our recommended extends approach.