feat: veh/player static check, perf private attrs, color

package.json

@@ -1,6 +1,6 @@
 {
   "name": "omp-node-lib",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "Better with omp-node-ts",
   "main": "dist/bundle.js",
   "types": "dist/bundle.d.ts",

src/controllers/player/basePlayer.ts

@@ -92,19 +92,31 @@ export abstract class BasePlayer {
     return this._locale;
   }
   set locale(value: string) {
-    playerBus.emit(playerHooks.setLocale, { player: this, value });
+    playerBus.emit(playerHooks.setCommonProp, {
+      player: this,
+      prop: "_locale",
+      value,
+    });
   }
   get charset(): string {
     return this._charset;
   }
   set charset(value: string) {
-    playerBus.emit(playerHooks.setCharset, { player: this, value });
+    playerBus.emit(playerHooks.setCommonProp, {
+      player: this,
+      prop: "_charset",
+      value,
+    });
   }
   get isRecording() {
     return this._isRecording;
   }
   set isRecording(value) {
-    playerBus.emit(playerHooks.setIsRecording, { player: this, value });
+    playerBus.emit(playerHooks.setCommonProp, {
+      player: this,
+      prop: "_isRecording",
+      value,
+    });
   }
 
   constructor(id: number) {
@@ -566,8 +578,8 @@ export abstract class BasePlayer {
     }
     return playerFunc.CreateExplosionForPlayer(this.id, X, Y, Z, type, Radius);
   }
-  static isConnected<P extends BasePlayer>(player: P): boolean {
-    return playerFunc.IsPlayerConnected(player.id);
+  static isConnected(id: number): boolean {
+    return playerFunc.IsPlayerConnected(id);
   }
   isConnected(): boolean {
     return playerFunc.IsPlayerConnected(this.id);

src/controllers/player/playerBus.ts

@@ -3,9 +3,7 @@ import { EventBus } from "@/utils/eventBus";
 export enum playerHooks {
   pause = "OnPlayerPause",
   create = "OnPlayerEventCreate",
-  setLocale = "OnPlayerSetLocale",
-  setCharset = "OnPlayerSetCharset",
-  setIsRecording = "OnPlayerSetIsRecording",
+  setCommonProp = "OnPlayerSetCommonProp",
 }
 
 export const playerBus = new EventBus();

src/controllers/player/playerEvent.ts

@@ -312,14 +312,9 @@ export abstract class BasePlayerEvent<P extends BasePlayer> {
       this.onPause && this.onPause(player, player.lastUpdateTick);
     });
 
-    playerBus.on(playerHooks.setLocale, ({ player, value }) => {
-      Reflect.set(player, "_locale", value);
-    });
-    playerBus.on(playerHooks.setCharset, ({ player, value }) => {
-      Reflect.set(player, "_charset", value);
-    });
-    playerBus.on(playerHooks.setIsRecording, ({ player, value }) => {
-      Reflect.set(player, "_isRecording", value);
+    playerBus.on(playerHooks.setCommonProp, ({ player, prop, value }) => {
+      Reflect.set(player, prop, value);
+      this.players.set(player.id, player);
     });
   }
   findPlayerById(playerid: number) {
@@ -336,7 +331,7 @@ export abstract class BasePlayerEvent<P extends BasePlayer> {
     60
   );
   private static fpsHeartbeat = throttle((player: BasePlayer) => {
-    if (!BasePlayer.isConnected(player)) return;
+    if (!BasePlayer.isConnected(player.id)) return;
     const nowDrunkLevel = player.getDrunkLevel();
     if (nowDrunkLevel < 100) {
       player.setDrunkLevel(2000);

src/controllers/vehicle/baseVehicle.ts

@@ -384,6 +384,9 @@ export abstract class BaseVehicle {
   isValid(): boolean {
     return vehFunc.IsValidVehicle(this.id);
   }
+  static isValid(id: number): boolean {
+    return vehFunc.IsValidVehicle(id);
+  }
   getMatrix() {
     if (this.id === -1) return;
     return GetVehicleMatrix(this.id);

src/utils/colorUtils.ts

@@ -2,6 +2,7 @@
 
 export const rgba = (value: string | number): number => {
   if (typeof value === "number") return value;
+  if (typeof +value === "number" && !isNaN(+value)) return +value;
   if (value.charAt(0) === "#") {
     if (value.length === 4) {
       return parseInt(