feat: better way call player callback

dockfries · Aug 29, 2022 · 452c4d0 · 452c4d0
1 parent 17b12c3
commit 452c4d0
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/controllers/player.ts b/src/controllers/player.ts
@@ -19,6 +19,7 @@ export class BasePlayer {
   private lastFps = 0;
 
   public constructor() {
+    // Each instance can be called to callbacks, so you can split the logic.
     OnPlayerConnect((playerid: number): void => {
       if (playerid === this.id) this.OnConnect();
     });
@@ -78,12 +79,9 @@ OnPlayerConnect((playerid: number): void => {
   const p = new BasePlayer();
   p.id = playerid;
   BasePlayer.players.push(p);
-  // p.OnConnect();
 });
 
 OnPlayerDisconnect((playerid: number): void => {
-  const p = BasePlayer.findPlayerIdx(playerid);
-  if (p === -1) return;
-  // BasePlayer.players[p].OnDisconnect();
-  BasePlayer.players.splice(p, 1);
+  const pIdx = BasePlayer.findPlayerIdx(playerid);
+  if (pIdx !== -1) BasePlayer.players.splice(pIdx, 1);
 });