Skip to content

Update dotnet 3.1 (needed to support Apple Silicon M1) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

StefanScherer
Copy link
Contributor

This PR updates dotnet from 2.1 to 3.1 to fix an issue that was raised on Apple M1 mentioned in Docker Community Slack:

Hi, I was trying to run this docker sample on my Macbook Air M1 but I get the following errors. Any thoughts on how I could fix this?
Sample - https://github.com/dockersamples/example-voting-app

screenshot_2021-02-12_at_9 33 21_pm

It turns out that the dotnet 2.1 multi-arch image only supports linux/amd64 and linux/arm/v7, the newer dotnet 3.1 also has linux/arm64 in the manifest list.

I hope that doesn't break anything in the sample app. I could build and run it with a simple docker-compose up.

@StefanScherer StefanScherer changed the title Update dotnet 3.1 Update dotnet 3.1 (needed to support Apple Silicon M1) Feb 12, 2021
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
@StefanScherer
Copy link
Contributor Author

Hi @BretFisher
I've updated this PR and now the example-voting-app also runs on Apple silicon machines, I've tested it on macOS 11.3.1 with Docker Desktop 3.3.2 and new docker compose up 🎉
Are you able to merge this PR? 😅

@justincormack justincormack merged commit 5edf3f7 into dockersamples:master May 5, 2021
@StefanScherer StefanScherer deleted the update-dotnet-3-1 branch May 5, 2021 16:25
@BretFisher
Copy link
Collaborator

🎉

GhenaCadin pushed a commit to Pokfinner/example-voting-app that referenced this pull request Jan 4, 2025
…-3-1

Update dotnet 3.1 (needed to support Apple Silicon M1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants