update Kubernetes manifests to app/v1 and yaml parity #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update yaml to current deployment manifest defaults and try for more pairity between kube-deploy.yml and k8s-specifications
GhenaCadin
pushed a commit
to Pokfinner/example-voting-app
that referenced
this pull request
Jan 4, 2025
…oyments update Kubernetes manifests to app/v1 and yaml parity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated all Kubernetes yaml with the following benefits:
kube-deployment.ymlandk8s-specifications/*kube-deployment.ymlto break up the large fileNote that it's undocumented, but I believe that
kube-deployment.ymlis designed for Docker Desktop where LoadBalancer works vialocalhostand PersistentVolumeClaim works with local docker volumes, and thatk8s-specifications/*is more generic and only uses NodePort and no claims... but I could be wrong.