Optimize result image #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes some optimizations in the result service's image; - switch to `node:8.9-alpine`, which a smaller base image - use `https://` for the registry - use `COPY` instead of `ADD`, following best pracice - cleanup npm cache, and combine steps to reduce image size These changes bring down the image size from 248MB to 81.2MB Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ManoMarks
approved these changes
Jan 4, 2018
|
NICE @thaJeztah ! |
GhenaCadin
pushed a commit
to Pokfinner/example-voting-app
that referenced
this pull request
Jan 4, 2025
…ckerfile Optimize result image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes some optimizations in the result service's image;
node:8.9-alpine, which a smaller base imagehttps://for the registryCOPYinstead ofADD, following best praciceThese changes bring down the image size from 248MB to 81.2MB
ping @ManoMarks @BretFisher PTAL