-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Docker image tag(s) pushed:
Labels added to images:
|
QQ: can't all of the |
8d454dc
to
8883f80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I managed to trigger an error by removing the container that was used to clone a volume.
I left a small comment on the code.
I was expecting to have it configured in the frontend as well. I think it is valuable to have it even if the errors overlap the backend part:
- they can provide more context when it comes to debug (for example, what button has been clicked)
- also we might be surprised by some errors poping in, from my experience, it is better to have error monitoring with no errors rather than errors not monitored, especially when users can click on buttons and fill inputs 😅
Also, as an improvement, we could add more versions in the data to monitor if a bug is correctly fixed across versions
- the Docker Desktop version
- the Docker Extension backend version
- the versions of the @docker packages (when we have bugsnag in the frontend)
Finally, should we identify users the same way we do it for events? It could be interesting when debugging to see that prior to one error the user had another one for example.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but other than it lgtm 👍 Can't wait to have this deployed
No description provided.