Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

feat(lint): add eslint #56

Merged
merged 4 commits into from
Sep 2, 2022
Merged

feat(lint): add eslint #56

merged 4 commits into from
Sep 2, 2022

Conversation

lucbpz
Copy link
Contributor

@lucbpz lucbpz commented Aug 31, 2022

What does this PR do?

  • Adds eslint to our configuration so that every file has the same format.
  • Adds prettier.
  • Bumps the docker theme version and remove ts-expect-error from the docker palette.
  • Fix all TS errors.

Notes

  • Make sure you have the Prettier VSCode extension.
  • I haven't added anything to our GH Actions yet - we can do it in a separate PR.

@github-actions
Copy link

github-actions bot commented Aug 31, 2022

Docker image tag(s) pushed:

docker/volumes-backup-extension:pr-56

Labels added to images:

org.opencontainers.image.title=volumes-backup-extension
org.opencontainers.image.description=Back up, clone, restore, and share Docker volumes effortlessly.
org.opencontainers.image.url=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.source=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.version=pr-56
org.opencontainers.image.created=2022-09-01T15:35:15.837Z
org.opencontainers.image.revision=2516c946190e16a708db6bc11800f2587b9c3765
org.opencontainers.image.licenses=Apache-2.0

.gitignore Outdated Show resolved Hide resolved
@@ -28,7 +28,7 @@ const NotificationContext = createContext<INotificationContext>({
},
});

export const NotificationProvider: FC<{}> = ({ children }) => {
export const NotificationProvider: FC = ({ children }) => {
Copy link
Member

@benja-M-1 benja-M-1 Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I just reviewed https://github.com/docker/mercury-ui/pull/3852 which advocates to use function declaration over function expression. I guess it is too late to change it everywhere, but should we consider to move everything to the function declaration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe this could have a bigger impact on large codebases (pinata / hub) and although by having it here we can have consistency on how we write our code I wouldn't worry too much about extensions (or at least the ones already built). When we have a linter rule that forces that we can include it here as well. WDYT?

Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! When running npm start the project compiled successfully and no issues were found 👍

@gtardif gtardif merged commit 0af2faf into main Sep 2, 2022
@felipecruz91 felipecruz91 deleted the feature/lint branch September 2, 2022 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants