-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Docker image tag(s) pushed:
Labels added to images:
|
@@ -28,7 +28,7 @@ const NotificationContext = createContext<INotificationContext>({ | |||
}, | |||
}); | |||
|
|||
export const NotificationProvider: FC<{}> = ({ children }) => { | |||
export const NotificationProvider: FC = ({ children }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I just reviewed https://github.com/docker/mercury-ui/pull/3852 which advocates to use function declaration over function expression. I guess it is too late to change it everywhere, but should we consider to move everything to the function declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe this could have a bigger impact on large codebases (pinata / hub) and although by having it here we can have consistency on how we write our code I wouldn't worry too much about extensions (or at least the ones already built). When we have a linter rule that forces that we can include it here as well. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! When running npm start
the project compiled successfully and no issues were found 👍
What does this PR do?
eslint
to our configuration so that every file has the same format.prettier
.Notes