Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Return volume size as a numeric byte count #30

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

felipecruz91
Copy link
Contributor

@felipecruz91 felipecruz91 commented Aug 3, 2022

Originally the size returned by the backend was in human-readable format (e.g. 16.0 kB).

Now the backend returns both the byte count and the human-readable representation of the size of the volume: {"Bytes":16000,"Human":"16.0 kB"}

The human-readable is used in the size column of the table.

image

@felipecruz91 felipecruz91 marked this pull request as ready for review August 3, 2022 10:33
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Docker image tag(s) pushed:

felipecruz/vackup-docker-extension:pr-30

Labels added to images:

org.opencontainers.image.title=vackup-docker-extension
org.opencontainers.image.description=Docker Extension to backup and restore docker volumes.
org.opencontainers.image.url=https://github.com/felipecruz91/vackup-docker-extension
org.opencontainers.image.source=https://github.com/felipecruz91/vackup-docker-extension
org.opencontainers.image.version=pr-30
org.opencontainers.image.created=2022-08-03T10:33:23.851Z
org.opencontainers.image.revision=2be1c6a3e2e75ddb8e4c14e288e665feee04f604
org.opencontainers.image.licenses=MIT

Copy link
Contributor

@lucbpz lucbpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can review go code, but I reviewed the changes in the JS side and the feature is working 👍

@felipecruz91 felipecruz91 merged commit 1ead4b9 into main Aug 4, 2022
@felipecruz91 felipecruz91 deleted the fix/return-size-as-number branch August 4, 2022 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants