Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not remove builder using the docker driver #218

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

crazy-max
Copy link
Member

fixes #156

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested review from tonistiigi and jedevc March 9, 2023 23:08
@crazy-max crazy-max marked this pull request as ready for review March 9, 2023 23:08
@crazy-max crazy-max merged commit eb27bcb into docker:master Mar 10, 2023
@crazy-max crazy-max deleted the fix-builder-removal branch March 10, 2023 09:28
fuxingloh referenced this pull request in BirthdayResearch/jellyfishsdk Mar 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action)
| action | minor | `v2.4.1` -> `v2.5.0` |

---

### Release Notes

<details>
<summary>docker/setup-buildx-action</summary>

###
[`v2.5.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.5.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.1...v2.5.0)

- `cleanup` input to remove builder and temp files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/213](https://togithub.com/docker/setup-buildx-action/pull/213)
- do not remove builder using the `docker` driver by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/218](https://togithub.com/docker/setup-buildx-action/pull/218)
- fix current context as builder name for `docker` driver by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/209](https://togithub.com/docker/setup-buildx-action/pull/209)

**Full Changelog**:
docker/setup-buildx-action@v2.4.1...v2.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
scottames referenced this pull request in scottames/dots Apr 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action)
| action | minor | `v2.2.1` -> `v2.5.0` |

---

### Release Notes

<details>
<summary>docker/setup-buildx-action</summary>

###
[`v2.5.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.5.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.1...v2.5.0)

- `cleanup` input to remove builder and temp files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/213](https://togithub.com/docker/setup-buildx-action/pull/213)
- do not remove builder using the `docker` driver by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/218](https://togithub.com/docker/setup-buildx-action/pull/218)
- fix current context as builder name for `docker` driver by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/setup-buildx-action/pull/209](https://togithub.com/docker/setup-buildx-action/pull/209)

**Full Changelog**:
docker/setup-buildx-action@v2.4.1...v2.5.0

###
[`v2.4.1`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.4.1)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.0...v2.4.1)

- Get releases from actions toolkit by
[@&#8203;crazy-max](https://togithub.com/crazy-max)
([#&#8203;200](https://togithub.com/docker/setup-buildx-action/issues/200))
- Bump csv-parse from 5.3.3 to 5.3.4
([#&#8203;199](https://togithub.com/docker/setup-buildx-action/issues/199))

**Full Changelog**:
docker/setup-buildx-action@v2.4.0...v2.4.1

###
[`v2.4.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.4.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.3.0...v2.4.0)

- Don't depend on the GitHub API to check release by
[@&#8203;crazy-max](https://togithub.com/crazy-max)
([#&#8203;196](https://togithub.com/docker/setup-buildx-action/issues/196))

**Full Changelog**:
docker/setup-buildx-action@v2.3.0...v2.4.0

###
[`v2.3.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.3.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.2.1...v2.3.0)

- Use Octokit to check Buildx release on GitHub by
[@&#8203;crazy-max](https://togithub.com/crazy-max)
([#&#8203;191](https://togithub.com/docker/setup-buildx-action/issues/191)
[#&#8203;192](https://togithub.com/docker/setup-buildx-action/issues/192))
- Add version pinning information to the README by
[@&#8203;jedevc](https://togithub.com/jedevc)
([#&#8203;189](https://togithub.com/docker/setup-buildx-action/issues/189))
- Bump minimatch from 3.0.4 to 3.1.2
([#&#8203;182](https://togithub.com/docker/setup-buildx-action/issues/182))
- Bump csv-parse from 5.3.1 to 5.3.3
([#&#8203;181](https://togithub.com/docker/setup-buildx-action/issues/181))
- Bump json5 from 2.2.0 to 2.2.3
([#&#8203;184](https://togithub.com/docker/setup-buildx-action/issues/184))

**Full Changelog**:
docker/setup-buildx-action@v2.2.1...v2.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning annotation appears in Github Actions when post-build tries to clean up the builder
2 participants