feat: release automation works with signed commits#470
Merged
Conversation
There was a problem hiding this comment.
Review Summary
✅ This PR correctly enables signed commits/tags by switching from lightweight to annotated tags and adding context support for proper command execution. The changes are well-structured and consistent throughout the codebase.
The key improvement is changing git tag <tag> to git tag <tag> -m <tag>, which creates annotated tags that can be GPG-signed when Git is configured to do so (via tag.gpgsign=true). Lightweight tags cannot be signed, so this change is essential for the feature described in the PR title.
No issues found - the implementation is correct.
Benehiko
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.