Skip to content

feat: release automation works with signed commits#470

Merged
joe0BAB merged 2 commits intomainfrom
x/releaser
Feb 24, 2026
Merged

feat: release automation works with signed commits#470
joe0BAB merged 2 commits intomainfrom
x/releaser

Conversation

@joe0BAB
Copy link
Collaborator

@joe0BAB joe0BAB commented Feb 24, 2026

No description provided.

@joe0BAB joe0BAB self-assigned this Feb 24, 2026
@joe0BAB joe0BAB requested a review from Benehiko February 24, 2026 07:55
@joe0BAB joe0BAB marked this pull request as ready for review February 24, 2026 07:58
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

✅ This PR correctly enables signed commits/tags by switching from lightweight to annotated tags and adding context support for proper command execution. The changes are well-structured and consistent throughout the codebase.

The key improvement is changing git tag <tag> to git tag <tag> -m <tag>, which creates annotated tags that can be GPG-signed when Git is configured to do so (via tag.gpgsign=true). Lightweight tags cannot be signed, so this change is essential for the feature described in the PR title.

No issues found - the implementation is correct.

@joe0BAB joe0BAB merged commit c181168 into main Feb 24, 2026
16 checks passed
@joe0BAB joe0BAB deleted the x/releaser branch February 24, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants