added example issue number to kitematic contributors guide instead of… #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moxiegirl @FrenchBen I updated the online docs version of the Kitematic Contirbutors' Guide w/some copy-edits, and added the issue # we used for the example (same as the Gist http://git.io/v8d55), can you guys take a quick look at let me know if it's good to go? Thanks! Vicky |
| $ git push origin xxxx-branch:xxxx-branch | ||
|
|
||
| where _xxxx_ is the number of the issue your worked on. | ||
| $ git push origin 1191-branch |
There was a problem hiding this comment.
this needs to be git push origin 1191-branch:1191-branch in order to create the remote branch with the same name as the local branch.
The above only works if the remote branch exists and has the same name
…de create of new branch, and references to repo name now docker/kitematic Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
|
@FrenchBen Thanks! I think I got them all. Let me know, thanks for the quick review. |
|
LGTM |
londoncalling
added a commit
that referenced
this pull request
Dec 29, 2015
added example issue number to kitematic contributors guide instead of… Merging this, @moxiegirl I got all Ben's comments in, and re-ran make docs to check it. LGTM 👍 :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… placeholders, and copyedit fixes
Signed-off-by: Victoria Bialas victoria.bialas@docker.com