Skip to content

fix: avoid re-downloading models already present in local store #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pnkcaht wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −0
Open

fix: avoid re-downloading models already present in local store #641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3238f7
fix: avoid re-downloading models already present in local store
Pnkcaht Feb 5, 2026
ad99cee
fix: limit cache fast-path to immutable digest references
Pnkcaht Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pkg/distribution/distribution/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,30 @@ func (c *Client) PullModel(ctx context.Context, reference string, progressWriter
originalReference := reference
// Normalize the model reference
reference = c.normalizeModelName(reference)

// Fast-path only for immutable digest references.
// Tags may be mutable and must be checked against the registry.
if strings.Contains(reference, "@") {
if localModel, err := c.store.Read(reference); err == nil {
c.log.Infoln("Model found in local store by digest:", utils.SanitizeForLog(reference))

cfg, err := localModel.Config()
if err != nil {
return fmt.Errorf("getting cached model config: %w", err)
}

if err := progress.WriteSuccess(
progressWriter,
fmt.Sprintf("Using cached model: %s", cfg.GetSize()),
oci.ModePull,
); err != nil {
c.log.Warnf("Writing progress: %v", err)
}

return nil
}
}

c.log.Infoln("Starting model pull:", utils.SanitizeForLog(reference))

// Handle bearer token for registry authentication
Expand Down