-
Notifications
You must be signed in to change notification settings - Fork 474
updates details for brave search #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates details for brave search #99
Conversation
|
@ipedrazas could we get your review on this one please? |
hspencer77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
|
Hey, thanks for this contribution. One small issue: if you try to build and run the tools by running this command:
You will see that the docker image is built correctly, but the tools cannot be listed (probably because it needs the correct configuration set). We only push to Hub images that list tools. Is there any chance that you can make the listing tools not require a valid connection? |
|
Thank you, @ipedrazas. I will take a look at that change ASAP and follow up with a commit. |
ed4384a to
57eff1d
Compare
Docker's mcp-registry/internal/mcp/client.go file pulls values from the env.example key when standing up the server, prior to requesting the tool list. The mcp-registry expects stdio to be the transport whereon tools are listed, but the "http" example in server.yaml causes the MCP Server to launch with an HTTP Transport, thus breaking the flow.
|
@ipedrazas The fix appears to simple; just needed to change the mcp-registry/internal/mcp/client.go Lines 189 to 198 in 00d9af2
|
|
Thank you @ipedrazas. |
|
@ipedrazas how/when would https://hub.docker.com/r/mcp/brave-search and https://hub.docker.com/mcp/server/brave/overview get updated? And have |
I have verified that
task buildsucceeds (with a small change for Windows).The
task catalogcommand also passes, however it does show an incorrect summary of tools, presumably untilhttp://desktop.docker.com/mcp/catalog/v2/tools/brave.jsonis updated—it is unclear to me when/how this resource gets updated.