add vpc-id and zone options for ec2 #98
Conversation
ehazlett
force-pushed
the
ec2-use-vpc
branch
from
da30a18 to
4fe401e
Compare
|
hmm odd -- i will check -- nothing should have updated |
ehazlett
force-pushed
the
ec2-use-vpc
branch
from
97d2e59 to
611ad8f
Compare
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
ehazlett
force-pushed
the
ec2-use-vpc
branch
from
611ad8f to
8881812
Compare
|
There should probably be a default zone so we don't have to specify it every time, right? |
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
|
@bfirsh agreed. updated. |
|
-1 on removing the subnet-id. You can have multiple subnets per AZ, e.g. as http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_Scenario2.html describes, so would want control at that level. Happy to have it use either vpc-id & zone or subnet-id (not allow all three!) & search for subnet as you've done if that wasn't specified, but it sounds a bit messy/confusing. Are subnet id's that much harder to find than VPC ids? |
|
It's more steps for the user and most are familiar with VPCs but may not be On Tuesday, December 16, 2014, Tristan Keen notifications@github.com
|
|
How is it more steps for the user? I agree it's easier for humans to talk about regions & availability zones & the likely single VPC id rather than opaque subnet ids, but you have to specify a subnet id when making a new instance so they're not that unknown. Whilst most personal AWS accounts will only have the default single subnet in each zone of the default VPC per region, I'm sure most businesses will move on to more than that. AFAIK you cannot change a subnet id after creation without messing with ENIs (messy & manual) so it would be best to retain the ability to choose one rather than just use the first in the right region/AZ. If you think having both options messy, then just drop the PR. I'd vote to leave in both methods, as you can default the region & AZ to fixed text constants that can work, and so only require subnet ids for non-trivial setups like ours. TBH I can't believe no-one else is commenting on this - am I misunderstanding something? |
|
I have no issue leaving all options and then adding logic to check if the specified conflict. |
|
Thanks - can then suit both user roles if there's a bit more documenting to do. |
ehazlett
changed the title
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
|
@tyrken would you mind checking out the latest? this will use a subnet-id if specified and look for the first one in the region/zone if not. |
|
Looks valid apart from I think it would be useful to throw an error if both specified and there is a discrepancy. But not managed to get it built & tested yet - suspect user error somehow |
|
cool. thanks for the feedback. On Wednesday, December 17, 2014, Tristan Keen notifications@github.com
|
add vpc-id and zone options for ec2
…status-vm if you kill the VBoxHeadless process, the state is set to aborted (happe...
AWS driver: Detect root device name from AMI
Fix provisioning for Docker 23+ for some of the provisioners Closes docker#98 See merge request https://gitlab.com/gitlab-org/ci-cd/docker-machine/-/merge_requests/102 Merged-by: Tomasz Maczukin <tomasz@maczukin.pl> Approved-by: Axel von Bertoldi <avonbertoldi@gitlab.com> Reviewed-by: Tomasz Maczukin <tomasz@maczukin.pl>
This removes the
subnet-idoption in favor ofvpc-idandzone. This is more practical for the end user. For example, instead of digging for a subnet id, simply specify a vpc-id and zone (such asvpc-0d2344anda).