This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Added a Disk Size parameter for Google Compute Engine. #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,7 @@ Options: | |||
|
|
|||
| - `--google-zone`: The zone to launch the instance. Default: `us-central1-a` | |||
| - `--google-machine-type`: The type of instance. Default: `f1-micro` | |||
| - `--google-disk-size`: The disk size of the instance (in GiB). Default: `10` | |||
There was a problem hiding this comment.
could you change this to GB to keep consistency with the rest of the docs?
|
Tested on GCE. Works as expected. |
saturnism
force-pushed
the
google-driver-disk-size
branch
from
f8025ec to
b237b24
Compare
Signed-off-by: Ray Tsang <saturnism@gmail.com>
saturnism
force-pushed
the
google-driver-disk-size
branch
from
b237b24 to
56d832d
Compare
|
Changed GiB to GB. Cheers! |
|
LGTM |
ehazlett
added a commit
that referenced
this pull request
Feb 10, 2015
Added a Disk Size parameter for Google Compute Engine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ray Tsang saturnism@gmail.com