This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Move cmd files under cmd/docker-machine to make it go-install-able #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Signed-off-by: Ivan Markin <sw@nogoegst.net>
|
@shin- WDYT? I like that but 2 years ago, when I tried something similar it was a bit of a no no for reasons I don't recall. |
|
Let's merge this and see if someone cries |
|
@dgageot wow this is intense |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (most of the time for me) it's much easier to just
go getdocker-machine rather than cloning it somewhere and runmake build(and have make!).This PR moves some files around while standard
makeworkflow remains the same. It enables to do this: