-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
😍 |
@nogoegst Please ping me when it's ready to review |
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Please sign your commits following these rules: $ git clone -b "dep" git@github.com:nogoegst/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354611080
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Ivan Markin <sw@nogoegst.net>
@dgageot, I think it is ready for review. 😉 |
|
@nogoegst Can you update those instructions too? https://github.com/docker/machine/blob/master/CONTRIBUTING.md#restore-update-and-save-dependencies |
@nogoegst Forget about it. It's just me being drunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typos
CONTRIBUTING.md
Outdated
#### Save the dependencies to `vendor/` | ||
|
||
make dep-save | ||
When you make a fresh copy of the repo, all the dependecies are in `vendor/` directory for the builds to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/dependecies/dependencies/
CONTRIBUTING.md
Outdated
make dep-save | ||
When you make a fresh copy of the repo, all the dependecies are in `vendor/` directory for the builds to work. | ||
This project uses [golang/dep](https://github.com/golang/dep) as vendor management tool. Please refer to `dep` documentation | ||
on further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/on/for/
CONTRIBUTING.md
Outdated
#### Save the dependencies to `vendor/` | ||
|
||
make dep-save | ||
When you make a fresh copy of the repo, all the dependecies are in `vendor/` directory for the builds to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/builds/build/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw there are multiple options to build I guess. That's why there was 'builds'.
@nogoegst Please fix the typos and then I think we are good to go \o/ |
Signed-off-by: Ivan Markin <sw@nogoegst.net>
Signed-off-by: Ivan Markin <sw@nogoegst.net>
@dgageot fixed, thanks! |
LGTM |
@vdemeester or @shin- would you have a moment to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM 🐸
@vdemeester Thanks! |
Imprortant notice: this PR updates vendor of following packages:
Probably removing of obsolete godep files should be here as well.