This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Fix argument escaping for scp on Windows #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-
force-pushed
the
4302-scp-commandline-win
branch
4 times, most recently
from
c066b44 to
f6cfabb
Compare
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
4302-scp-commandline-win
branch
from
f6cfabb to
7055c02
Compare
|
LGTM |
|
Any idea on when this fix is going to be pushed to the official docker toolbox installer? docker-machine scp still cannot be used. |
|
In the next release. You can also install the new RC manually in the meantime: https://github.com/docker/machine/releases/tag/v0.14.0-rc1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed to work when I tested it on Windows. Sources:
Fixes #4302
cc @dgageot