This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
[hyperv] if no vswitch is specified, only pick the first external one #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dowideit, Sven (O&A, St. Lucia) <Sven.Dowideit@csiro.au>
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid the pathological case where the hyper-v driver defaults to the dockerNat vSwitch (which happens to most users that have never knowingly used hyper-v before, but have install Docker for Windows.)
And still allows the knowledgeable user to create and specify a vswitch explicitly.
This should remove some of the things users need to remember when creating a hyperv vm - https://rominirani.com/docker-machine-windows-10-hyper-v-troubleshooting-tips-367c1ea73c24