add opt-in skip for missing login credentials#925
Open
crazy-max wants to merge 2 commits intodocker:masterfrom
Open
add opt-in skip for missing login credentials#925crazy-max wants to merge 2 commits intodocker:masterfrom
crazy-max wants to merge 2 commits intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
skip-optin
branch
from
62218e2 to
0d13a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/github-builder#117 (comment)
Adds an opt-in environment variable,
DOCKER_LOGIN_SKIP_IF_MISSING_CREDS, to skip login whenusernameorpasswordis missing. This helps workflows like forked pull requests where secrets are not exposed. Default behavior is unchanged, so missing credentials still fail unless the env is enabled.