Bump Go to 1.17.5 and start using modules #218
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| language: go | ||
|
|
||
| go: | ||
| - 1.17.5 | ||
|
|
||
| # let us have speedy Docker-based Travis workers | ||
| sudo: false | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| module github.com/docker/libkv | ||
|
|
||
| go 1.17 | ||
|
|
||
| require ( | ||
| github.com/coreos/etcd v3.3.25+incompatible | ||
| github.com/go-zookeeper/zk v1.0.2 | ||
| github.com/hashicorp/consul v0.5.2 | ||
| github.com/stretchr/testify v1.7.0 | ||
| go.etcd.io/bbolt v1.3.6 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310 // indirect | ||
| github.com/coreos/bbolt v1.3.3 // indirect | ||
| github.com/coreos/go-semver v0.3.0 // indirect | ||
| github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf // indirect | ||
| github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f // indirect | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect | ||
| github.com/dustin/go-humanize v1.0.0 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||
| github.com/golang/protobuf v1.5.2 // indirect | ||
| github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c // indirect | ||
| github.com/google/uuid v1.3.0 // indirect | ||
| github.com/gorilla/websocket v1.4.2 // indirect | ||
| github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect | ||
| github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect | ||
| github.com/hashicorp/go-msgpack v0.5.3 // indirect | ||
| github.com/hashicorp/golang-lru v0.5.0 // indirect | ||
| github.com/hashicorp/hcl v1.0.0 // indirect | ||
| github.com/jonboulle/clockwork v0.2.2 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/kr/pretty v0.1.0 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/prometheus/client_golang v1.11.0 // indirect | ||
| github.com/soheilhy/cmux v0.1.5 // indirect | ||
| github.com/stretchr/objx v0.1.1 // indirect | ||
| github.com/tmc/grpc-websocket-proxy v0.0.0-20201229170055-e5319fda7802 // indirect | ||
| github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2 // indirect | ||
| go.uber.org/zap v1.19.1 // indirect | ||
| golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4 // indirect | ||
| golang.org/x/sys v0.0.0-20210603081109-ebe580a85c40 // indirect | ||
| golang.org/x/time v0.0.0-20211116232009-f0f3c7e86c11 // indirect | ||
| google.golang.org/genproto v0.0.0-20211208223120-3a66f561d7aa // indirect | ||
| google.golang.org/grpc v1.40.0 // indirect | ||
| gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect | ||
| sigs.k8s.io/yaml v1.3.0 // indirect | ||
| ) | ||
|
|
||
| replace google.golang.org/grpc => google.golang.org/grpc v1.23.0 | ||
|
Member
There was a problem hiding this comment. note that |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI seems broken, I will open a PR to fix it first if you want. SGTY @thaJeztah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, although don't spend too much time on it; we really need to reduce use of this dependency (it's good to know if things are not broken of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a huge jump 1.8 > 1.17, better to do that in a follow-up 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm just being very opportunistic and putting all my trust in Go's backwards compatibility promise 😹
And, to be fair, this has already been built in Moby using all mort recent versions of Go...