Skip to content

chore(release): add Go proxy refresh automation#117

Merged
mdelapenya merged 1 commit intodocker:mainfrom
mdelapenya:refresh-golangproxy
Oct 24, 2025
Merged

chore(release): add Go proxy refresh automation#117
mdelapenya merged 1 commit intodocker:mainfrom
mdelapenya:refresh-golangproxy

Conversation

@mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Oct 24, 2025

Summary

  • Add refresh-proxy.sh script to trigger pkg.go.dev to fetch newly released module versions
  • Add refresh-proxy and refresh-proxy-all Makefile targets for easy invocation
  • Refactor version extraction into shared get_version_from_file() function in common.sh
  • Update check-pre-release.sh to use common functions for better maintainability

Test plan

  • Verify make refresh-proxy works from individual module directories
  • Verify make refresh-proxy-all refreshes all modules
  • Confirm version extraction works correctly with various whitespace patterns

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings October 24, 2025 05:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds automation to trigger pkg.go.dev to fetch newly released Go module versions by introducing a refresh-proxy script and Makefile targets. The PR also refactors version extraction into a shared utility function.

  • Introduces refresh-proxy.sh script to trigger Go proxy updates for individual modules
  • Adds refresh-proxy and refresh-proxy-all Makefile targets for convenient invocation
  • Refactors version extraction into shared get_version_from_file() function in common.sh for reusability

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
commons-test.mk Adds refresh-proxy target for individual module proxy refresh
Makefile Adds refresh-proxy-all target to refresh all modules
.github/scripts/refresh-proxy.sh New script that reads module version and triggers Go proxy refresh via curl
.github/scripts/common.sh Adds shared get_version_from_file() helper function for version extraction
.github/scripts/check-pre-release.sh Updates to use shared version extraction function and common.sh variables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add refresh-proxy script and targets to automate triggering pkg.go.dev
to fetch newly released module versions. Refactor common version
extraction logic into shared function.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@mdelapenya mdelapenya requested a review from Copilot October 24, 2025 05:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mdelapenya mdelapenya requested a review from Copilot October 24, 2025 05:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mdelapenya mdelapenya self-assigned this Oct 24, 2025
@mdelapenya mdelapenya merged commit 8dfd9f0 into docker:main Oct 24, 2025
9 checks passed
@mdelapenya mdelapenya deleted the refresh-golangproxy branch October 24, 2025 05:37
mdelapenya added a commit to ndeloof/go-sdk that referenced this pull request Nov 6, 2025
* main:
  feat(wait): add human-readable String() methods to all wait strategies (docker#119)
  feat(image): display formatted pull progress on Windows terminals (docker#118)
  chore(release): add Go proxy refresh automation (docker#117)
  chore(release): bump module versions
  chore(release): prevent for pushing to personal forks (docker#115)
  chore(release): add pre-release checks to make the release process more consistent (docker#114)
  chore(volume): return pointer in FindByID (docker#105)
  fix(container): proper error message on empty container names (docker#113)
  fix(container): add to nil modifiers (docker#112)
  feat(container): add new functional options to add container config, hostConfig and endpointSettings (docker#111)
  feat(container): configure pull handler at container creation (docker#110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant