Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase mkdoc version to 1.2.2. #204

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

atline
Copy link
Contributor

@atline atline commented Oct 6, 2021

python:alpine is now points to python3.10, with old mkdoc, it will reports:

from collections import Sequence, namedtuple
ImportError: cannot import name 'Sequence' from 'collections' (/usr/local/lib/python3.10/collections/__init__.py)

This is due to:

Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

Signed-off-by: atline atline@aliyun.com

python:alpine is now points to python3.10, with old mkdoc, it will reports:

```
from collections import Sequence, namedtuple
ImportError: cannot import name 'Sequence' from 'collections' (/usr/local/lib/python3.10/collections/__init__.py)
```

This is due to:
> Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

Signed-off-by: atline <atline@aliyun.com>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix 🙏

@glours glours merged commit 7ceaaee into docker:master Oct 8, 2021
@glours glours mentioned this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants