Update samples #108
Update samples #108
Conversation
| @@ -1,4 +1,4 @@ | |||
| FROM node:14.17-alpine3.13 AS client-builder | |||
| FROM node:17.7-alpine3.14 AS client-builder | |||
There was a problem hiding this comment.
Upgrade to latest node version
There was a problem hiding this comment.
I believe this Dockerfile was created automatically as a result of docker extension init.
I think we should update the boilerplate as well: https://github.com/docker/desktop-extensions-cli/blob/main/cmd/desktopcmds/initialize/initdata/Dockerfile#L14
There was a problem hiding this comment.
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-scripts": "4.0.3", | ||
| "react-scripts": "5.0.0", |
There was a problem hiding this comment.
Make react-script work on node 17
| <DockerMuiThemeProvider> | ||
| <CssBaseline /> | ||
| <App /> | ||
| </DockerMuiThemeProvider> |
There was a problem hiding this comment.
Show how to use the theme.
| @@ -1,2 +1,36 @@ | |||
| extension: ## Build service image to be deployed as a desktop extension | |||
| docker build --tag=desktop-react-extension . | |||
| IMAGE?=desktop-react-extension | |||
There was a problem hiding this comment.
changes made in this makefile are backported to the cli in this PR https://github.com/docker/desktop-extensions-cli/pull/59
| @@ -3,7 +3,7 @@ FROM scratch | |||
| LABEL org.opencontainers.image.title="SwimmingWhale" \ | |||
| org.opencontainers.image.description="A sample plugin that just displays a whale swimming." \ | |||
| org.opencontainers.image.vendor="Docker Inc." \ | |||
| com.docker.desktop.extension.api.version="1.0.0-beta.1" | |||
| com.docker.desktop.extension.api.version=">= 0.2.0" | |||
There was a problem hiding this comment.
@gtardif This extension was one of the first that was developed. Should we target >= 0.1.0 instead?
There was a problem hiding this comment.
well, this is minor, but for the docs, i'd prefer to not confuse users and stick with >= 0.2.0 consistenty with other samples
This PR upgrades the
api.versionlabel to>= 0.2.0.It also adds the Docker Desktop theme into the React example: