Updated Archive Script #9073
Merged
Updated Archive Script #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docsdocker ready! Built with commit 8121f4e |
allysmith424
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@allysmith424 I was doing a bit of testing on the Archive script and noticed it wasn't working correctly.
The script is meant to "clean out" the content in folders that are not part of an archive release. I.e. Docker Hub which is live content. However somewhere along the line the script stopped working.
This is whats meant to happen:
Which is the case in https://docs.docker.com/v17.06/docker-hub/ however this currently isn't happening, so all the Docker hub content is still in the archive image i.e. https://docs.docker.com/v18.03/docker-hub/.
Affected archive images 17.12, 18.03 which probably should be retrospectively cleaned up.
This makes more sense why we have to manually remove the entries from the ToC after your run the archive script, the content should be deleted! But its not today, hence why index.md is still being served rather than index.html after we clean up the ToC.
Unreleased project version (optional)
Related issues (optional)