-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit signing images #8882
Merged
Merged
Edit signing images #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for docsdocker ready! Built with commit 178d9eb |
bermudezmt
commented
Jun 3, 2019
ollypom
suggested changes
Jun 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) A couple of the nits but the rest looks good.
- Change example Security member name
Thanks, @ollypom |
bermudezmt
added a commit
that referenced
this pull request
Jun 5, 2019
* Fix broken links * Update link to webhook types * Rewritten Custom CNI to become Unmanaged CNI in UCP Docs (#8799) Here I have rewritten the Unmanaged CNI page with Docker UCP. The changes are: - Clarifying the support position - Providing clear instructions on how to bring up UCP and then install a custom CNI plugin - Removes unneccesary items like disabling IPIP which is not related to this page. Signed-off-by: Olly Pomeroy <olly@docker.com> * Updated following Uday's feedback * Add editorial review * Fix link preview * Update link to UCP installation * Fix typo * Standardize headings * removed the reference to index.md Though the sections referenced belong to `index.md`, there is no requirement to call it out in the URL. For example: https://docs.docker.com/docker-for-mac/#add-tls-certificates https://docs.docker.com/docker-for-mac/#reset * Update faqs.md * Update ubuntu version and common driver on storagedriver docs (#8746) Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com> * refactor Jenkinsfile - use DTR images for all but `docker.github.io:published` - use environment variables instead of credentials - build and push all images inside VPN container - combine build + image and update swarm stages - remove repetitive steps / stages * 7724 (#8876) * Fix 7724 * Fix broken link * Change to Docker Enterprise (#8877) * Change to Docker Enterprise * Update the new default addr pool for swarm (#8705) The default address pool for swarm is now a `/8` CIDR * Update part2.md (#8535) typo * Update system-requirements.md * Clean up syntax (#8881) * Removed 2018 references. (#8880) * Remove pay thru Docker section (#8879) * Update index.md * Edit signing images (#8882) * Edit signing images * Incorporate feedback * Final edits - Change example Security member name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Unreleased project version (optional)
Related issues (optional)