Skip to content

Document SSH usage for Docker builder#7731

Merged
7 commits merged intomasterfrom
ssh-docker-build-usage-826
Dec 10, 2018
Merged

Document SSH usage for Docker builder#7731
7 commits merged intomasterfrom
ssh-docker-build-usage-826

Conversation

@ahh-docker
Copy link
Contributor

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@ahh-docker ahh-docker self-assigned this Nov 20, 2018
@ahh-docker ahh-docker requested a review from thaJeztah November 20, 2018 19:16
@ahh-docker
Copy link
Contributor Author

The command line reference material is being updated here:
#7753

Capitalized headers.
@GordonTheTurtle
Copy link

GordonTheTurtle commented Nov 27, 2018

Deploy preview for docsdocker ready!

Built with commit 0762046

https://deploy-preview-7731--docsdocker.netlify.com

@ahh-docker
Copy link
Contributor Author

@andrewhsu can you please review? If it looks good, lemme know. Thanks!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some thoughts inline

thaJeztah and others added 3 commits November 27, 2018 19:18
Co-Authored-By: ahh-docker <41210220+ahh-docker@users.noreply.github.com>
Co-Authored-By: ahh-docker <41210220+ahh-docker@users.noreply.github.com>
@ahh-docker
Copy link
Contributor Author

@andrewhsu Can I get your help reviewing this? I need some questions answered so I can get this pushed through the process. thanks.

Included technical edits from @andrewhsu.
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my comments for consideration

@JustinINevill JustinINevill assigned ghost and unassigned ahh-docker Dec 10, 2018
@ghost ghost dismissed thaJeztah’s stale review December 10, 2018 19:59

technical fixes implemented; editorial change also implemented.

@ghost
Copy link

ghost commented Dec 10, 2018

GTG

@ghost ghost merged commit 51d2167 into master Dec 10, 2018
@usha-mandya usha-mandya deleted the ssh-docker-build-usage-826 branch February 21, 2019 17:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants