Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified rebuild and publish as part of iterating on app #4737

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Clarified rebuild and publish as part of iterating on app #4737

merged 2 commits into from
Sep 28, 2017

Conversation

londoncalling
Copy link
Contributor

What's changed

  • Added information about needing to rebuild and push a new image if you change your app source code

Relevant topics on Netlify preview

TBD

Related

Reviewers

@wilhelm-si

Signed-off-by: Victoria Bialas victoria.bialas@docker.com

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Copy link
Contributor

@gbarr01 gbarr01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Scale the app by changing the `docker-compose.yml` file.

Change the app behavior by editing code.
Change the app behavior by editing code, rebuild, and push the new image. (To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe it should be editing, rebuilding, pushing?

@londoncalling londoncalling merged commit 3c97bc9 into docker:master Sep 28, 2017
@londoncalling londoncalling deleted the 3824-get-started branch September 28, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants