Stop gap measure to fix data persistence part of the tutorial #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2017 18:01
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
friism
reviewed
Sep 27, 2017
| @@ -85,7 +85,7 @@ with the following. Be sure to replace `username/repo:tag` with your image detai | |||
| visualizer: | |||
| image: dockersamples/visualizer:stable | |||
| ports: | |||
| - "8080:8080" | |||
| - "8080:8080": | |||
There was a problem hiding this comment.
I can't speak for whether it is intentional but I can confirm that it doesn't actually break YAML.
There was a problem hiding this comment.
it's not intentional, I believe. I'll remove it. Working with @shin- on this problem today.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Added back in
docker-machine scpanddocker-machine sshcommands in part 5 to get the the data persistence step with theredisservice to work. With the current Compose file, when you run thedocker stack deploycommand on the local host withmyvm1active, Docker looks for the~./datadirectory on the local host, not on the remote machine,myvm1.Added an override to the
rediscommand in the Compose file to get the data to persist.Related
Addresses #4723, but we will leave the issue open to further research getting this to work without
scpif possible.Related PR is #4675
Reviewers
@shin- @friism @johndmulhausen @jasonmevans @mstanleyjones
Signed-off-by: Victoria Bialas victoria.bialas@docker.com