Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d4win doesn't start automatically w/installer in elevated mode, add d… #4204

Merged
merged 5 commits into from
Aug 15, 2017
Merged

d4win doesn't start automatically w/installer in elevated mode, add d… #4204

merged 5 commits into from
Aug 15, 2017

Conversation

londoncalling
Copy link
Contributor

@londoncalling londoncalling commented Aug 15, 2017

What's changed

  • Updates to docs on Docker for Windows install to reflect new behavior. Docker doesn't start automatically anymore after install. (This is due to the mode the new installers run in, and issues that were related to automatic start of the app.)

Related

Fixes #4196
Fixes #4565

Reviewers

@dgageot @friism @cowlinator

Signed-off-by: Victoria Bialas victoria.bialas@docker.com

…ocs and pix

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Victoria Bialas added 3 commits August 15, 2017 11:49
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one teensy suggestion. 👼


If you just installed the app, you also get a popup success message with suggested next steps, and a link to this documentation.
When the whale in the status bar stays steady, Docker is up-and-running, and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe lose the hyphens in "up and running"?

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
@londoncalling londoncalling merged commit 3798359 into docker:master Aug 15, 2017
@londoncalling londoncalling deleted the d4win-installer branch August 18, 2017 04:52
shin- pushed a commit to shin-/docker.github.io that referenced this pull request Aug 19, 2017
docker#4204)

* d4win doesn't start automatically w/installer in elevated mode, add docs and pix

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* resized images to be smaller

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* clarified finding status bar whale for install

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* fixed image

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* fixed link

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants