removed incorrect description of how to link to a service #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
fermayo
approved these changes
Aug 10, 2017
mdlinville
approved these changes
Aug 10, 2017
shin-
pushed a commit
to shin-/docker.github.io
that referenced
this pull request
Aug 19, 2017
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Removed paragraph about linking to a service using username as part of a pretty URL, as it's incorrect.
Here are some relevant threads in Forums, if we think it's necessary to mention CNAMES at this point (doesn't seem so though in this topic):
Related
Fixes #4124
Reviewers
@mochawich @fermayo @KickingTheTV @mstanleyjones @JimGalasyn
Signed-off-by: Victoria Bialas victoria.bialas@docker.com