Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH key path option to Digital Ocean doc #415

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Add SSH key path option to Digital Ocean doc #415

merged 1 commit into from
Nov 9, 2016

Conversation

v4n
Copy link

@v4n v4n commented Nov 1, 2016

Modify the docs based on this PR docker/machine#3761

@v4n
Copy link
Author

v4n commented Nov 1, 2016

@nathanleclaire might want to check PR along the docker/machine PR when you get a chance.

@mdlinville
Copy link

The upstream PR only seems to be against the machine repo's master. If this is a new feature, the doc PR needs to be against vnext-machine rather than master Please rebase if necessary.

@londoncalling PTAL

@v4n
Copy link
Author

v4n commented Nov 4, 2016

@mstanleyjones this is indeed a new feature that has been merged into machine's master.

Correct me if I'm wrong. But isn't this PR already pointed to be merged into vnext-machine rather than master?

v4n wants to merge 1 commit into docker:vnext-machine from v4n:vnext-machine

@mdlinville
Copy link

Oh, you are right! Sorry, I missed that.

@qembot
Copy link

qembot commented Nov 8, 2016

Pull request #415 - Add SSH key path option to Digital Ocean doc is now ready for functional validation.

Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdlinville mdlinville merged commit dd0ba78 into docker:vnext-machine Nov 9, 2016
@v4n v4n deleted the vnext-machine branch February 18, 2017 17:23
joaofnfernandes added a commit to joaofnfernandes/docker.github.io that referenced this pull request Apr 16, 2018
* /enterprise -> /ee
* /datacenter/dtr/2.5 -> /ee/dtr/
* /datacenter/ucp/3.0->/ee/ucp
* Fix configs
* Fix broken images
* Remove unused images for DTR
* Remove unused images for UCP
* Add a few redirects to avoid breaking beta exercises
JimGalasyn pushed a commit that referenced this pull request Apr 16, 2018
* /enterprise -> /ee
* /datacenter/dtr/2.5 -> /ee/dtr/
* /datacenter/ucp/3.0->/ee/ucp
* Fix configs
* Fix broken images
* Remove unused images for DTR
* Remove unused images for UCP
* Add a few redirects to avoid breaking beta exercises
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants