Convert Library references from submodule to upstream #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndmulhausen
changed the title
|
LGTM though I feel like the script could use some improvements like using a heredoc instead of all the echoes. Maybe @thaJeztah can provide some input since he's really good at this. Though you may not be able to use the |
mdlinville
approved these changes
Aug 8, 2017
|
@mstanleyjones Let's think about what we want to do here and iterate. Merging since the guts work and we need the infra fix. |
|
Thanks for the feedback! |
mdlinville
pushed a commit
that referenced
this pull request
Aug 8, 2017
This reverts commit 1c5153b.
shin-
pushed a commit
to shin-/docker.github.io
that referenced
this pull request
Aug 19, 2017
* Step 1 of getting to upstream-based model * Upstream part 2 * Working front-matter generation * Pages generating * TOC fixes, autogen fixes, test>prod script * Boilerplate fix * Switch to cat, redundancy removals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in Library refs via shell script and using Jekyll collections will save a lot of grief over using the submodule system.
To test, run
docker build -t doctest .and thendocker run -p 4000:4000 -ti doctestNetlify can complete builds created with this system; generation time on this PR was 7.35 minutes, well within the timeout range of 15 minutes.
jekyll buildrun locally from a normal authoring clone (which grabs nothing from upstream) is 3.89 minutes.docker buildrun locally from this branch (which grabs everything from upstream) finishes generation in 5.4 minutes.This also ensures that our copy of "library" is up to date and kills the dependency between shell files and upstream files, which was always bound to break. The library is very active and now we can just use what they have, whatever that is.