d4mac, d4win 17.06.1 stable, 17.07.0 edge release #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
londoncalling
requested review from
mdlinville,
johndmulhausen,
JimGalasyn and
thaJeztah
|
You shouldn't base this on master should you? |
mdlinville
approved these changes
Jul 31, 2017
|
@mstanleyjones I'll wait to merge until the release is out |
added 3 commits
August 23, 2017 13:32
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
londoncalling
changed the title
added 2 commits
August 23, 2017 13:38
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
mdlinville
reviewed
Aug 23, 2017
| - Diagnose can be cancelled & Improved help information. Fixes [docker/for-mac#1134](https://github.com/docker/for-mac/issues/1134), [docker/for-mac#1474](https://github.com/docker/for-mac/issues/1474) | ||
| - Support paging of Docker Cloud [repositories](/docker-cloud/builds/repos.md) and [organizations](/docker-cloud/orgs.md). Fixes [docker/for-mac#1538](https://github.com/docker/for-mac/issues/1538) | ||
|
|
||
| ### Docker Community Edition 17.06.1-ce-mac20, 2017-07-18 (edge) |
There was a problem hiding this comment.
This is duplication of line 22 and I guess it's out of order?
There was a problem hiding this comment.
@mstanleyjones I think you are seeing the entries for Stable and Edge
There was a problem hiding this comment.
It's the same build number mac20. I don't see how the same build number can be both stable and edge.
|
@mstanleyjones this is the way these are shown on stable and edge changelogs, which speaks to the problems we were talking about earlier, so leaving for now and I'll show you the changelogs in the private repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Reviewers
@jeanlaurent @friism @ebriney @djs55
Signed-off-by: Victoria Bialas victoria.bialas@docker.com