Better examples to show Compose file structure, expand/collapse accordion #3967
Conversation
londoncalling
requested review from
mdlinville,
thaJeztah,
johndmulhausen and
joaofnfernandes
compose/compose-file/index.md
Outdated
| <div class="panel-heading" role="tab" id="headingThree"> | ||
| <h5 class="panel-title" id="collapsible-group-item-3"> <a class="" role="button" data-toggle="collapse" data-parent="#accordion" data-target="#collapseThree" aria-expanded="true" aria-controls="collapseThree"> Example Compose file version 3 </a> </h5> | ||
| </div> | ||
| <div id="collapseThree" class="panel-collapse collapse" role="tabpanel" aria-labelledby="headingThree" aria-expanded="true"> |
There was a problem hiding this comment.
💥 sweet!
Not a major issue, but the compose file includes 6 spaces, so when I copy this sample to my text editor I'll have to remove those spaces to make this sample work.
Try to remove the leading spaces in lines 58-146, that might do the trick
There was a problem hiding this comment.
@joaofnfernandes great suggestion, have a look now, should be good.
FYI, @dnephin @shin- I'm going to look into the possibility of pulling this file from the voting app sample source on GitHub in the long term.
compose/compose-file/index.md
Outdated
| placement: | ||
| constraints: [node.role == manager] | ||
|
|
||
| networks: |
There was a problem hiding this comment.
Almost there. Network and volumes need to be aligned with services, so you need to remove 2 spaces from lines 141-146
londoncalling
changed the title
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
|
@mstanleyjones @joaofnfernandes @johndmulhausen @shin- Please take a look if you get a chance. Accordion menu implemented for Compose sample config file, and instructions added in |
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
…and content Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
londoncalling
changed the title
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
| } | ||
|
|
||
| .panel-heading:hover{ | ||
| background: #fafdfe; |
There was a problem hiding this comment.
Can you please use background-color? background is a hybrid which can take a color and an image together. This is a nit but it's more correct.
|
LGTM with additional fixes to polish up the accordions, test/fix for mobile, and full explanation in |
…dion (docker#3967) * better examples to show Compose file structure Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * cleaned up leading spaces in Compose file example Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * cleaned up leading spaces, added a test file Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * expand/collapse accordion full implementation, explanation in test.md Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * delete temporary test file from PR Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * fix accordion to work on mobile (cursor style) Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * verified fix for mobile worked, added same to test.md, updated notes and content Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * Clarifed details on test page, fixed references for FontAwesome icons Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
What's changed
buildandvolumesub-options toserviceRelated
Fixes #1349
Fixes #3955
Reviewers fyi
@shin- @MicheleMannino @Capricorn1
Signed-off-by: Victoria Bialas victoria.bialas@docker.com