Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prerequisite for docker-machine #3449

Closed
wants to merge 1 commit into from
Closed

Conversation

jkorab
Copy link

@jkorab jkorab commented May 31, 2017

Added Docker Machine to prerequisites section, alongside link to install

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Added Docker Machine to prerequisites section, alongside link to install
@mdlinville
Copy link

I don't think this is needed on Docker for Mac or Docker for Windows or Docker EE for Windows Server. PTAL @londoncalling

@mdlinville mdlinville requested a review from londoncalling June 2, 2017 17:04
@londoncalling
Copy link
Contributor

@jkorab well, you have a good point, as you would need to install Docker Machine on Linux. (It comes with Docker for Mac and Windows.) But it should be up in the prerequisites. I'm working on a PR with edit suggestions for the Getting Started tutorial as a whole. I'm going to close this PR, but cc you on that other PR, which is #3294. I'll add this change to mention the need for Docker Machine on Linux into that PR.

Copy link
Contributor

@londoncalling londoncalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants